Pd-cvs January 2008

pd-cvs@lists.iem.at

13 participants
134 discussions

pd/src s_path.c,1.11.6.2,1.11.6.3
by Russell Bryant 06 Jan '08

06 Jan '08

Update of /cvsroot/pure-data/pd/src In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv7626 Modified Files: Tag: branch-v0-40-extended s_path.c Log Message: (add patch from issue #1852385) This patch provides a revised implementation of the strtokcpy() function in s_path.c. It provides the following benefits: 1) Prevent potential overflow of a stack buffer. This function did nothing to ensure that it didn't write past the end of the destination buffer. It is possible to cause this to happen by providing certain command line arguments that are longer than MAXPDSTRING. Also, there may be other ways to trigger this bug if namelist_append_files() is used anywhere beyond the uses I reviewed, which are the ones in pd/*.c. 2) Copy bytes from the string in the same loop that looks for the delimiter. This is simply for efficiency in that the string only has to be traversed once, instead of twice (one to find the delimiter, and the second to copy up to it). Index: s_path.c =================================================================== RCS file: /cvsroot/pure-data/pd/src/s_path.c,v retrieving revision 1.11.6.2 retrieving revision 1.11.6.3 diff -C2 -d -r1.11.6.2 -r1.11.6.3 *** s_path.c 6 Jan 2008 03:43:08 -0000 1.11.6.2 --- s_path.c 6 Jan 2008 14:39:09 -0000 1.11.6.3 *************** *** 73,91 **** /******************* Utility functions used below ******************/ ! /* copy until delimiter and return position after delimiter in string */ ! /* if it was the last substring, return NULL */ ! ! static const char* strtokcpy(char *to, const char *from, int delim) { ! int size = 0; ! while (from[size] != (char)delim && from[size] != '\0') ! size++; ! strncpy(to,from,size); ! to[size] = '\0'; ! if (from[size] == '\0') return NULL; ! if (size) return from+size+1; ! else return NULL; } --- 73,99 ---- /******************* Utility functions used below ******************/ ! /*! ! * \brief copy until delimiter ! * ! * \arg to destination buffer ! * \arg to_len destination buffer length ! * \arg from source buffer ! * \arg delim string delimiter to stop copying on ! * ! * \return position after delimiter in string. If it was the last ! * substring, return NULL. ! */ ! static const char *strtokcpy(char *to, size_t to_len, const char *from, char delim) { ! unsigned int i = 0; ! for (; i < (to_len - 1) && from[i] && from[i] != delim; i++) ! to[i] = from[i]; ! to[i] = '\0'; ! if (i && from[i] != '\0') ! return from + i + 1; ! ! return NULL; } *************** *** 135,139 **** do { ! npos = strtokcpy(temp, npos, SEPARATOR); if (! *temp) continue; nl = namelist_append(nl, temp, 0); --- 143,147 ---- do { ! npos = strtokcpy(temp, sizeof(temp), npos, SEPARATOR); if (! *temp) continue; nl = namelist_append(nl, temp, 0);

1 0

externals/ggee/signal stream.h,1.2,1.3
by Russell Bryant 06 Jan '08

06 Jan '08

Update of /cvsroot/pure-data/externals/ggee/signal In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv2842/signal Modified Files: stream.h Log Message: (Merge the rest of my changes from issue #1848356) When I first starting looking into different ways to stream audio into Pd, I spent a little bit of time looking at streamin~/streamout~. While looking at it, I fixed the security issue from the previous commit, and made the following updates to stream.h. - Adding doxygen style comments. - Add an ifdef to prevent against multiple or recursive includes of the header. - Document most of the fields in the defined data structures. - Fix potential alignment bugs (at least on platforms using GNUC) by using the packed attribute for structures defining network frames. See http://gcc.gnu.org/onlinedocs/gcc-4.2.2/gcc/Variable-Attributes.html#Variab… - Point out the fact that this code is not endianness-safe, and that it should eventually be updated to respect network byte order. - Point out that the version field of the frame header is ignored when parsing incoming frames. - Change a list of #defines to an enum. - Instead of using "int" in the frame header structure, use int32_t to explicitly state that the field is 32-bits. Index: stream.h =================================================================== RCS file: /cvsroot/pure-data/externals/ggee/signal/stream.h,v retrieving revision 1.2 retrieving revision 1.3 diff -C2 -d -r1.2 -r1.3 *** stream.h 22 May 2005 20:48:00 -0000 1.2 --- stream.h 6 Jan 2008 14:30:28 -0000 1.3 *************** *** 1,29 **** /* (C) Guenter Geiger 1999 */ ! #define SF_FLOAT 1 ! #define SF_DOUBLE 2 ! #define SF_8BIT 10 ! #define SF_16BIT 11 ! #define SF_32BIT 12 ! #define SF_ALAW 20 ! #define SF_MP3 30 ! #define SF_SIZEOF(a) (a == SF_FLOAT ? sizeof(t_float) : a == SF_16BIT ? sizeof(short) : 1) ! typedef struct _tag { /* size (bytes) */ ! char version; /* 1 */ ! char format; /* 1 */ ! int count; /* 4 */ ! char channels; /* 1 */ ! int framesize; /* 4 */ ! char extension[5]; /* 5 */ ! } t_tag; /*--------------*/ ! /* 16 */ typedef struct _frame { ! t_tag tag; ! char* data; } t_frame; --- 1,74 ---- /* (C) Guenter Geiger 1999 */ ! /*! ! * \file ! * \author Guenter Geiger ! * ! * \brief Definitions used by both streamin~ and streamout~ ! * ! * \todo This code does not honor network byte order. ! */ ! #ifndef __PD_STREAM_H ! #define __PD_STREAM_H + #include <inttypes.h> + /*! + * \brief Format identifiers for frames + */ + enum tag_format { + SF_FLOAT = 1, + SF_DOUBLE = 2, + SF_8BIT = 10, + SF_16BIT = 11, + SF_32BIT = 12, + SF_ALAW = 20, + SF_MP3 = 30 + }; ! #define SF_SIZEOF(a) (a == SF_FLOAT ? sizeof(t_float) : a == SF_16BIT ? sizeof(short) : 1) + #ifdef __GNUC__ + #define PACKED __attribute__ ((packed)) + #endif + /*! + * \brief 16-byte frame header + * + * \note Version 1 + */ + typedef struct _tag { + /*! Frame header version. Currently ignored in streamin, but always set + * to 1 for streamout. + * + * \todo Add version checking on incoming frames. However, this could + * break existing uses of the external. */ + char version; + /*! This field identifies the type of data is in the frame payload */ + char format; + /*! ??? */ + int32_t count; + /*! ??? */ + char channels; + /*! This indicates the full size of the frame. It is basically + * ( sizeof(t_tag) + payload length ). */ + int32_t framesize; + /*! ??? */ + char extension[5]; + } PACKED t_tag; + + + /*! + * \brief A complete frame + */ typedef struct _frame { ! /*! This is the frame header that contains the metadata about the frame */ ! t_tag tag; ! /*! This buffer stores the frame data payload. The amount of data in this ! * buffer is the tag.framesize - sizeof(t_tag). Its contents can be ! * interpreted according to the tag.version. */ ! char *data; } t_frame; + + #endif /* __PD_STREAM_H */

1 0

externals/ggee/signal streamin~.c,1.9,1.10
by Russell Bryant 06 Jan '08

06 Jan '08

Update of /cvsroot/pure-data/externals/ggee/signal In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv31630/signal Modified Files: streamin~.c Log Message: Fix a security issue. streamin~ was vulnerable to a remotely exploitable heap buffer overflow that could potentially allow an attacker to execute arbitrary code on a machine that is using streamin~. The issue is that the defined frame header includes a field for frame size which indicates how much additional data is available. However, this frame size was not checked to ensure that it was smaller than the size of the buffer that was allocated to store this data. (one of my patches from issue #1848356) Index: streamin~.c =================================================================== RCS file: /cvsroot/pure-data/externals/ggee/signal/streamin~.c,v retrieving revision 1.9 retrieving revision 1.10 diff -C2 -d -r1.9 -r1.10 *** streamin~.c 3 Jul 2007 11:04:57 -0000 1.9 --- streamin~.c 6 Jan 2008 14:20:04 -0000 1.10 *************** *** 157,160 **** --- 157,166 ---- ret = recv(x->x_socket, (char*) &x->frames[x->framein].tag,sizeof(t_tag),0); + if ((x->frames[x->framein].tag.framesize - sizeof(t_tag)) > MAXFRAMESIZE) { + error("streamin~: got an invalid frame size of %d, maximum is %d\n", + x->frames[x->framein].tag.framesize, MAXFRAMESIZE); + x->frames[x->framein].tag.framesize = MAXFRAMESIZE + sizeof(t_tag); + } + x->nbytes = n = x->frames[x->framein].tag.framesize; }

1 0

autobuild: pd-extended ubuntu-dapper-i386 2008-01-06 07.35.22
by pd＠ubuntu-dapper-i386.idmi.poly.edu 06 Jan '08

06 Jan '08

checking for shm_open in -lrt... yes checking for jack_set_xrun_callback in -ljack... yes checking for jack_set_error_function in -ljack... yes MORECFLAGS --------------- -O6 -funroll-loops -fomit-frame-pointer checking for special C compiler options needed for large files... no checking for _FILE_OFFSET_BITS value needed for large files... 64 checking for _LARGE_FILES value needed for large files... no ./configure: line 7923: syntax error near unexpected token `SINF,' ./configure: line 7923: `AST_EXT_LIB_CHECK(SINF, m, sinf)' make[1]: [pd] Error 2 (ignored) make -C /home/pd/auto-build/pd-extended/pd/src BUILDLAYOUT_DIR=/home/pd/auto-build/pd-extended/packages cvs_root_dir=/home/pd/auto-build/pd-extended DESTDIR=/home/pd/auto-build/pd-extended/packages/linux_make/build/ prefix=/usr/local libpddir=/home/pd/auto-build/pd-extended/packages/linux_make/build//usr/local/lib/pd OPT_CFLAGS="-O2 -mcpu=i686 -march=i386" UNAME=Linux install make[2]: Entering directory `/home/pd/auto-build/pd-extended/pd/src' make[2]: *** No rule to make target `install'. Stop. make[2]: Leaving directory `/home/pd/auto-build/pd-extended/pd/src' make[1]: *** [pd_install] Error 2 make[1]: Leaving directory `/home/pd/auto-build/pd-extended/packages' make: *** [install] Error 2 upload specs linux_make . deb Uploading /home/pd/auto-build/pd-extended/packages/linux_make/./Pd*.deb ls: /home/pd/auto-build/pd-extended/packages/linux_make/./Pd*.deb: No such file or directory

1 0

autobuild: pd-main debian-testing-i386 2008-01-06 06.25.10
by pd＠debian-testing-i386.idmi.poly.edu 06 Jan '08

06 Jan '08

pd/portmidi/CVS/Entries pd/portmidi/pm_mac/ pd/portmidi/pm_mac/CVS/ pd/portmidi/pm_mac/CVS/Entries pd/portmidi/pm_win/ pd/portmidi/pm_win/CVS/ pd/portmidi/pm_win/CVS/Entries pd/portmidi/porttime/ pd/portmidi/porttime/CVS/ pd/portmidi/porttime/CVS/Entries pd/src/ pd/src/CVS/ pd/src/CVS/Entries scripts/ scripts/CVS/ scripts/CVS/Entries sent 4154 bytes received 420429 bytes 77196.91 bytes/sec total size is 91101987 speedup is 214.57 autoheader: error: AC_CONFIG_HEADERS not found in configure.in

1 0

autobuild: pd-extended debian-testing-i386 2008-01-06 06.25.10
by pd＠debian-testing-i386.idmi.poly.edu 06 Jan '08

06 Jan '08

checking for snd_pcm_info in -lasound... yes checking for shm_open in -lrt... yes checking for jack_set_xrun_callback in -ljack... yes checking for jack_set_error_function in -ljack... yes MORECFLAGS --------------- -O6 -funroll-loops -fomit-frame-pointer checking for special C compiler options needed for large files... no checking for _FILE_OFFSET_BITS value needed for large files... 64 ./configure: line 8298: syntax error near unexpected token `SINF,' ./configure: line 8298: `AST_EXT_LIB_CHECK(SINF, m, sinf)' make[1]: [pd] Error 2 (ignored) make -C /home/pd/auto-build/pd-extended/pd/src BUILDLAYOUT_DIR=/home/pd/auto-build/pd-extended/packages cvs_root_dir=/home/pd/auto-build/pd-extended DESTDIR=/home/pd/auto-build/pd-extended/packages/linux_make/build/ prefix=/usr/local libpddir=/home/pd/auto-build/pd-extended/packages/linux_make/build//usr/local/lib/pd OPT_CFLAGS="-O2 -mcpu=i686 -march=i386" UNAME=Linux install make[2]: Entering directory `/home/pd/auto-build/pd-extended/pd/src' make[2]: *** No rule to make target `install'. Stop. make[2]: Leaving directory `/home/pd/auto-build/pd-extended/pd/src' make[1]: *** [pd_install] Error 2 make[1]: Leaving directory `/home/pd/auto-build/pd-extended/packages' make: *** [install] Error 2 upload specs linux_make . deb Uploading /home/pd/auto-build/pd-extended/packages/linux_make/./Pd*.deb ls: /home/pd/auto-build/pd-extended/packages/linux_make/./Pd*.deb: No such file or directory

1 0

autobuild: desiredata debian-testing-i386 2008-01-06 06.25.10
by pd＠debian-testing-i386.idmi.poly.edu 06 Jan '08

06 Jan '08

pd/CVS/ pd/CVS/Entries pd/doc/ pd/doc/7.stuff/ pd/doc/7.stuff/CVS/ pd/doc/7.stuff/CVS/Entries pd/doc/CVS/ pd/doc/CVS/Entries pd/extra/ pd/extra/CVS/ pd/extra/CVS/Entries pd/src/ pd/src/configure scripts/ scripts/CVS/ scripts/CVS/Entries sent 5595 bytes received 603263 bytes 48708.64 bytes/sec total size is 89802122 speedup is 147.49 autoheader: error: AC_CONFIG_HEADERS not found in configure.in

1 0

autobuild: pd-extended planetccrma6-i386 2008-01-06 04.32.54
by pd＠planetccrma6-i386.idmi.poly.edu 06 Jan '08

06 Jan '08

checking for shm_open in -lrt... yes checking for jack_set_xrun_callback in -ljack... yes checking for jack_set_error_function in -ljack... yes MORECFLAGS --------------- -O6 -funroll-loops -fomit-frame-pointer checking for special C compiler options needed for large files... no checking for _FILE_OFFSET_BITS value needed for large files... 64 checking for _LARGE_FILES value needed for large files... no ./configure: line 7985: syntax error near unexpected token `SINF,' ./configure: line 7985: `AST_EXT_LIB_CHECK(SINF, m, sinf)' make[1]: [pd] Error 2 (ignored) make -C /home/pd/auto-build/pd-extended/pd/src BUILDLAYOUT_DIR=/home/pd/auto-build/pd-extended/packages cvs_root_dir=/home/pd/auto-build/pd-extended DESTDIR=/home/pd/auto-build/pd-extended/packages/linux_make/build/ prefix=/usr/local libpddir=/home/pd/auto-build/pd-extended/packages/linux_make/build//usr/local/lib/pd OPT_CFLAGS="-O2 -mcpu=i686 -march=i386 -ftree-vectorize -ftree-vectorizer-verbose=3" UNAME=Linux install make[2]: Entering directory `/home/pd/auto-build/pd-extended/pd/src' make[2]: *** No rule to make target `install'. Stop. make[2]: Leaving directory `/home/pd/auto-build/pd-extended/pd/src' make[1]: *** [pd_install] Error 2 make[1]: Leaving directory `/home/pd/auto-build/pd-extended/packages' make: *** [install] Error 2 upload specs linux_make build tar.bz2 Uploading /home/pd/auto-build/pd-extended/packages/linux_make/build/Pd*.tar.bz2 ls: /home/pd/auto-build/pd-extended/packages/linux_make/build/Pd*.tar.bz2: No such file or directory

1 0

autobuild: pd-extended macosx104-powerpc 2008-01-06 03.15.02
by pd＠macosx104-powerpc.idmi.poly.edu 06 Jan '08

06 Jan '08

checking for main in -ltcl8.5... no checking for main in -ltcl84... no checking for main in -ltcl8.4... yes checking for main in -ltk85... no checking for main in -ltk8.5... no checking for main in -ltk84... no checking for main in -ltk8.4... yes checking for special C compiler options needed for large files... no checking for _FILE_OFFSET_BITS value needed for large files... no checking for _LARGE_FILES value needed for large files... no ./configure: line 7979: syntax error near unexpected token `SINF,' ./configure: line 7979: `AST_EXT_LIB_CHECK(SINF, m, sinf)' make[1]: [pd] Error 2 (ignored) make -C /Users/pd/auto-build/pd-extended/pd/src BUILDLAYOUT_DIR=/Users/pd/auto-build/pd-extended/packages cvs_root_dir=/Users/pd/auto-build/pd-extended DESTDIR=/Users/pd/auto-build/pd-extended/packages/darwin_app/build/Pd-0.40.3-extended-20080106.app/Contents/Resources prefix= libpddir=/Users/pd/auto-build/pd-extended/packages/darwin_app/build/Pd-0.40.3-extended-20080106.app/Contents/Resources OPT_CFLAGS="-ftree-vectorize -ftree-vectorizer-verbose=2 -fast -fPIC -mcpu=7450 -mtune=7450" UNAME=Darwin install make[2]: *** No rule to make target `install'. Stop. make[1]: *** [pd_install] Error 2 make: *** [darwin_app_core] Error 2 upload specs darwin_app . dmg Uploading /home/pd/auto-build/pd-extended/packages/darwin_app/./Pd*.dmg ls: /home/pd/auto-build/pd-extended/packages/darwin_app/./Pd*.dmg: No such file or directory

1 0

autobuild: pd-extended macosx104-i386 2008-01-06 03.15.08
by pd＠macosx104-i386.idmi.poly.edu 06 Jan '08

06 Jan '08

checking for main in -ltcl8.5... no checking for main in -ltcl84... no checking for main in -ltcl8.4... yes checking for main in -ltk85... no checking for main in -ltk8.5... no checking for main in -ltk84... no checking for main in -ltk8.4... yes checking for special C compiler options needed for large files... no checking for _FILE_OFFSET_BITS value needed for large files... no checking for _LARGE_FILES value needed for large files... no ./configure: line 7979: syntax error near unexpected token `SINF,' ./configure: line 7979: `AST_EXT_LIB_CHECK(SINF, m, sinf)' make[1]: [pd] Error 2 (ignored) make -C /Users/pd/auto-build/pd-extended/pd/src BUILDLAYOUT_DIR=/Users/pd/auto-build/pd-extended/packages cvs_root_dir=/Users/pd/auto-build/pd-extended DESTDIR=/Users/pd/auto-build/pd-extended/packages/darwin_app/build/Pd-0.40.3-extended-20080106.app/Contents/Resources prefix= libpddir=/Users/pd/auto-build/pd-extended/packages/darwin_app/build/Pd-0.40.3-extended-20080106.app/Contents/Resources OPT_CFLAGS="-march=pentium4 -msse2 -mfpmath=sse -ftree-vectorize -ftree-vectorizer-verbose=2" UNAME=Darwin install make[2]: *** No rule to make target `install'. Stop. make[1]: *** [pd_install] Error 2 make: *** [darwin_app_core] Error 2 upload specs darwin_app . dmg Uploading /home/pd/auto-build/pd-extended/packages/darwin_app/./Pd*.dmg ls: /home/pd/auto-build/pd-extended/packages/darwin_app/./Pd*.dmg: No such file or directory

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
14
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

Pd-cvs January 2008